Skip to content

Conversation

Macro-ZJ
Copy link

@Macro-ZJ Macro-ZJ commented Aug 15, 2024

拉取/合并请求描述:(PR description)

[
[bsp][stm32][libraries]新增STM32H5部分BSP适配

为什么提交这份PR (why to submit this PR)

为STM32H5增加部分bsp

你的解决方案是什么 (what is your solution)

新增dma config和修改串口驱动V2版本以适配

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp\stm32\stm32h503-st-nucleo
  • .config:Null
  • action:Null

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mysterywolf mysterywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI编译没有过

@Rbb666 Rbb666 added the BSP: STM32 BSP related with ST/STM32 label Aug 15, 2024
@Macro-ZJ Macro-ZJ requested a review from mysterywolf August 16, 2024 01:25
@github-actions github-actions bot added the BSP label Aug 30, 2024
Copy link
Author

@Macro-ZJ Macro-ZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -24,6 +24,7 @@
/* USER CODE BEGIN Includes */
#include <drv_common.h>
/* USER CODE END Includes */
DMA_HandleTypeDef handle_GPDMA1_Channel0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

定义在这里,使用cubemx生成代码后会被覆盖。

if (RT_DEVICE_FLAG_DMA_RX == flag)
{
DMA_Handle->Init.Direction = DMA_PERIPH_TO_MEMORY;
#if defined(SOC_SERIES_STM32H5)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意格式缩进

@mysterywolf mysterywolf marked this pull request as draft October 5, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: STM32 BSP related with ST/STM32 BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants